aws / amazon-ecs-init

ecs-init is now part of the amazon-ecs-agent repo https://github.com/aws/amazon-ecs-agent/tree/master/ecs-init
https://github.com/aws/amazon-ecs-agent
Apache License 2.0
200 stars 117 forks source link

not failing create/remove calls if save state to disk fails #292

Closed sharanyad closed 4 years ago

sharanyad commented 4 years ago

Summary

In the current code, after successfully creating/mounting/removing volumes, if saving the volume info to disk fails, we return an error to Docker. This is not correct, since the volumes are actually successfully created/removed.

The state will be saved to disk again during the next create/remove call.

Testing

New tests cover the changes: yes

Description for the changelog

Licensing

This contribution is under the terms of the Apache 2.0 License: