aws / amazon-ecs-init

ecs-init is now part of the amazon-ecs-agent repo https://github.com/aws/amazon-ecs-agent/tree/master/ecs-init
https://github.com/aws/amazon-ecs-agent
Apache License 2.0
200 stars 117 forks source link

Add generic deb packaging #390

Closed sparrc closed 3 years ago

sparrc commented 3 years ago

Summary

Add generic deb packaging (one that is not specific to platform).

Implementation details

Some changes from the ubuntu-trusty packaging:

Testing

Built the deb and tested it on:

Verified that the service runs fine on these platforms.

Description for the changelog

N/A

Licensing

This contribution is under the terms of the Apache 2.0 License:

nmeyerhans commented 3 years ago

Omit the docker dependency. This is mainly because we have less control over docker outside of AL. it can come from "docker-ce", "docker" or "docker-ee", or even not from deb. so i omit this dependency in packaging;

The debian packaging format allows optional dependencies. You should specify a Docker dependency using something like: Depends: docker-ce | docker-ee | docker.io | docker

This obviously won't cover the case where it's not installed via a package, but for people going that route, they will have other issues, and other ways of satisfying the dependency.

We should not be leaving critical dependencies unspecified