search

aws / amazon-ecs-init

Amazon Elastic Container Service RPM
http://aws.amazon.com/ecs
Apache License 2.0
200 stars 118 forks source link

Fix incorrect build tag #394

Closed fenxiong closed 3 years ago

fenxiong commented 3 years ago

Summary

Fix incorrect build tag. Build tag generic-rpm isn't valid due to containing dash, and then the build defaults to unspecified config. Changing to underscore generic_rpm to fix the issue.

Implementation details

Fix the build tag.

Testing

Built the rpm and verified that the agent cgroup mount is now correct (previously not)

{
    "Type": "bind",
    "Source": "/sys/fs/cgroup",
    "Destination": "/sys/fs/cgroup",
    "Mode": "",
    "RW": true,
    "Propagation": "rprivate"
},

and agent is able to create cgroup without error:

...
level=info time=2021-02-19T19:45:11Z msg="Creating root ecs cgroup: /ecs" module=init_linux.go
level=info time=2021-02-19T19:45:11Z msg="Creating cgroup /ecs" module=cgroup_controller_linux.go
level=info time=2021-02-19T19:45:11Z msg="Event stream ContainerChange start listening..." module=eventstream.go
...

Description for the changelog

N/A

Licensing

This contribution is under the terms of the Apache 2.0 License: