search

aws / amazon-ecs-init

Amazon Elastic Container Service RPM
http://aws.amazon.com/ecs
Apache License 2.0
200 stars 118 forks source link

Configurable ecs-agent image version #406

Closed tomassejkora closed 2 years ago

tomassejkora commented 3 years ago

Summary

Enhancement request: Configurable ecs-agent image version

Description

We would like to have an option to override hard-coded default ecs-agent version set to the "latest" in order to we can lock ecs-agent version.

Expected Behavior

ecs-agent version should be configurable in order to we can lock version and test it pre-prod environments first. With the "latest" tag it may happen that version is accidentally upgraded in production environment under certain conditions.

Please let me know if there is already such option and we overlooked it.

mssrivas commented 3 years ago

Hi, thankyou for raising this issue. To understand more, we would like some information. Do you use ECS Optimized AMI or work with custom amis in general? If using ECS Optimized AMI, you could freeze the AMI to be used across regions to maintain.

tomassejkora commented 3 years ago

Hi,

Thank you for the response!

Yes we use ECS Optimized AMI with some tiny customization in user data and we do daily restart of ecs-agent due to some stability issues.

Freezing AMI doesn't help because in a rare case docker pulls the latest ecs-agent image during ecs-agent restart and the agent version is upgraded without any notice.

pparth commented 2 years ago

@mssrivas any updates here?

lydiafilipe commented 2 years ago

Hi, we would like to look more into why this update is occurring. Do you run yum update in your user data?

tomassejkora commented 2 years ago

Hi,

We don't run yum update in user data. There has to be a rare case when the ecs-agent image is pruned e.g. during ecs-agent restart. I tried to search for a recent case but I couldn't find any.

Realmonia commented 2 years ago

Hi @tomassejkora sorry for the late response, I tried to reproduce the issue but it seems the agent version is not updated with restart of ecs agent and ec2 instance. Is it only happening to some specific legacy ecs agent versions? Do you see it happen with recent releases of ecs agent?

tomassejkora commented 2 years ago

Hi @Realmonia, no problem. We regularly upgrade ecs agent and I couldn't see any case at least last 6 months. I checked agent versions in production today and it's consistent so maybe it was fixed.

Realmonia commented 2 years ago

Thanks for the response! I will close this issue then.