search

aws / amazon-ecs-init

Amazon Elastic Container Service RPM
http://aws.amazon.com/ecs
Apache License 2.0
199 stars 118 forks source link

Running "make deb" or "make generic-rpm" does not package amazon-ecs-volume-plugin #431

Closed dennisconrad closed 2 years ago

dennisconrad commented 3 years ago

Summary

Running make deb or make generic-rpm does not package the amazon-ecs-volume-plugin.

NB: make generic-rpm was not working at all on Red Hat Enterprise Linux 8.4; this PR fixes this as well.

Description

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package does not include the amazon-ecs-volume-plugin binary and startup scripts.

Expected Behavior

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package should include the amazon-ecs-volume-plugin binary and startup scripts.

Observed Behavior

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package does not include the amazon-ecs-volume-plugin binary and startup scripts.

Environment Details

Ubuntu 18.04 Bionic Red Hat Enterprise Linux 8.4

dennisconrad commented 3 years ago

Fixed by: ~https://github.com/aws/amazon-ecs-init/pull/432~ https://github.com/aws/amazon-ecs-init/pull/433

Realmonia commented 2 years ago

PR is merged. Close this issue. Thanks for the contribution!