search

aws / amazon-ecs-init

Amazon Elastic Container Service RPM
http://aws.amazon.com/ecs
Apache License 2.0
199 stars 118 forks source link

Include amazon-ecs-volume-plugin and startup scripts in Debian Package #432

Closed dennisconrad closed 3 years ago

dennisconrad commented 3 years ago

Summary

This PR ensures make deb includes amazon-ecs-volume-plugin binary and startup scripts in the resulting Debian package

Fixes https://github.com/aws/amazon-ecs-init/issues/431

Implementation details

Modify Debian build scripts.

Testing

Built on Ubuntu 18.04 Bionic and tested to work.

New tests cover the changes: no

Description for the changelog

Include amazon-ecs-volume-plugin and startup scripts in Debian package

Licensing

This contribution is under the terms of the Apache 2.0 License: yes

ubhattacharjya commented 3 years ago

Hi @dennisconrad ,

Thank you for submitting this change. I have following comments for this PR.

  1. Can you please change the base branch to aws:dev ?
  2. Can you please add the same changes for generic-rpm as well?
dennisconrad commented 3 years ago

Hi @dennisconrad ,

Thank you for submitting this change. I have following comments for this PR.

  1. Can you please change the base branch to aws:dev ?
  2. Can you please add the same changes for generic-rpm as well?

I did my very best on the generic RPM. https://github.com/aws/amazon-ecs-init/pull/433

Closing this PR.