search

aws / amazon-ecs-init

Amazon Elastic Container Service RPM
http://aws.amazon.com/ecs
Apache License 2.0
199 stars 118 forks source link

Include amazon-ecs-volume-plugin in Debian and Generic RPM Packages #433

Closed dennisconrad closed 2 years ago

dennisconrad commented 3 years ago

Summary

This PR ensures the amazon-ecs-volume-plugin binary and startup scripts are included in the Debian and generic RPM packages built via the Makefile.

Implementation details

Modify Debian and generic RPM build scripts and Makefile.

Testing

Tested on Ubuntu 18.04 Bionic and Red Hat Enterprise Linux 8.4.

New tests cover the changes: no

Description for the changelog

Include amazon-ecs-volume-plugin in Debian and Generic RPM Packages

Licensing

This contribution is under the terms of the Apache 2.0 License: yes

dennisconrad commented 3 years ago

Fixes https://github.com/aws/amazon-ecs-init/issues/431

mssrivas commented 3 years ago

Hi, Could you elaborate on testing performed for this?

dennisconrad commented 2 years ago

I am not quote sure how to answer this for changes to the packaging of a product...

We are running Ubuntu in our environment, and I copied the existing amazon-ecs-volume-plugin.service and amazon-ecs-volume-plugin.socket systemctl configuration files into the generic-deb directories and ensured the amazon-ecs-volume-plugin binary is included in the resulting package. I checked that all required files are included in the generated .deb packaged by running dpkg -c <package>, then installed the package, and mounted an EFS file system that requires IAM permissions and transitEncryption to be mounted inside a docker container running on the Ubuntu system (which requires the amazon-ecs-volume-plugin). This is running in production for 1+ months now in our organisation.

I followed a similar approach with the generic RPM package, except that I ran rpm -qpl <package> to check the included files and installed it on a Red Hat Enterprise Linux 8.4 and mounted an EFS file system as above. I have no long-term results for these since, as mentioned above, we are running Ubuntu 18.04 and no Red Hat in our environment.

gunzy83 commented 2 years ago

Thanks for the change. I have built the Debian package for 18.04 as well and we have included this in our AMI and we have had this running in ops environments for about a month and production for about a week. We have only needed EFS in our ops environment so far but we build one AMI for all environments so the ECS agent bootstrapping definitely works reliably.

dennisconrad commented 2 years ago

@mssrivas Do you require anything else from me? You keep releasing new versions which we then manually need to patch to deploy it to our servers.

viccsjain commented 2 years ago

Is this PR merged and released?