Closed dennisconrad closed 2 years ago
@mssrivas @sparrc Can you please have a look at the failing tests for this PR? I don't see how my changes could have caused this to fail. Thank you!
Hi @dennisconrad , I reran the failed test and it passed. I will do some more manual testing from my side and then we can merge this if everything is good
Summary
This PR ensures
make deb
includes amazon-ecs-volume-plugin binary and startup scripts in the resulting Debian packageFixes https://github.com/aws/amazon-ecs-init/issues/431
Implementation details
Modify Debian build scripts.
Testing
Built on Ubuntu 18.04 Bionic and tested to work.
New tests cover the changes:
No automated tests, but we are running Ubuntu in our environment, and I copied the existing amazon-ecs-volume-plugin.service and amazon-ecs-volume-plugin.socket systemctl configuration files into the generic-deb directories and ensured the amazon-ecs-volume-plugin binary is included in the resulting package. I checked that all required files are included in the generated .deb packaged by running dpkg -c, then installed the package, and mounted an EFS file system that requires IAM permissions and transitEncryption to be mounted inside a docker container running on the Ubuntu system (which requires the amazon-ecs-volume-plugin). This is running in production for several months now in our organisation.
Description for the changelog
Include amazon-ecs-volume-plugin and startup scripts in Debian package
Licensing
This contribution is under the terms of the Apache 2.0 License: yes