search

aws / amazon-ecs-service-connect-agent

Amazon ECS Service Connect Agent
Apache License 2.0
29 stars 11 forks source link

Add TCP keep alive for relay bootstrap #51

Closed shenjianan97 closed 10 months ago

shenjianan97 commented 1 year ago

Summary

This change adds TCP keep alive to relay bootstrap to keep relay's connection with its upstream in case of idle timeout for TCP connections.

Implementation details

Following official Envoy doc: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/address.proto#envoy-v3-api-msg-config-core-v3-tcpkeepalive to configure the keep alive.

Testing

Build image locally and using it for testing.

  1. Make sure the change won't impact current behavior of SC.
  2. Make sure the change be able fix the current issue.

New tests cover the changes: yes

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

suniltheta commented 10 months ago

Good to close this PR?

suniltheta commented 10 months ago

going to close this PR. we can re-raise if we think this is needed again.