search

aws / amazon-ecs-service-connect-agent

Amazon ECS Service Connect Agent
Apache License 2.0
27 stars 10 forks source link

disable hot restart capability in Envoy on bootup #61

Closed suniltheta closed 9 months ago

suniltheta commented 9 months ago

Summary

Explicitly disable Envoy hot restart capability via cli option while start Envoy process

Potential for some user to run into issue to start Envoy process because the Envoy container don't have access to some shared memory folder like in https://github.com/envoyproxy/envoy/issues/4195

We can't ask user to take the step mentioned in one of the comment https://github.com/envoyproxy/envoy/issues/4195#issuecomment-415547470 since not all users have access inside Envoy container.

Implementation details

In start command include --disable-hot-restart

Testing

New tests cover the changes: yes

Description for the changelog

disable hot restart while starting Envoy proxy process

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.