aws / amazon-ecs-service-connect-agent

Amazon ECS Service Connect Agent
Apache License 2.0
27 stars 10 forks source link

Remove envoy.reloadable_feature.successful_active_health_check_uneject_host #64

Closed suniltheta closed 9 months ago

suniltheta commented 9 months ago

To be included with v1.28+ releases only and not before.

Summary

From v1.28 Envoy release this feature flag has been removed in https://github.com/envoyproxy/envoy/pull/29303. See Envoy v1.28.0 release notes.

healthcheck: Removed envoy.reloadable_features_successful_active_health_check_uneject_host runtime option and substituted it with outlier_detection.successful_active_health_check_uneject_host outlier detection configuration flag.

Implementation details

Revert of earlier change https://github.com/aws/amazon-ecs-service-connect-agent/pull/38

Testing

New tests cover the changes: yes

Description for the changelog

Removed option to set envoy.reloadable_feature.successful_active_health_check_uneject_host

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.