aws / amazon-ecs-service-connect-agent

Amazon ECS Service Connect Agent
Apache License 2.0
27 stars 10 forks source link

Ability to set use_http_client_to_fetch_aws_credentials #65

Closed suniltheta closed 8 months ago

suniltheta commented 9 months ago

Include this change only on v1.29.x, v1.30.x Envoy release. Or on v1.28.x if upstream commits on Envoy release v1.29 are ported back.

From v1.31.x onwards this feature flag is going to be removed.

Summary

Ability to set envoy.reloadable_features.use_http_client_to_fetch_aws_credentials, which defaults to false.

Following the changes in Envoy to deprecated libcurl, we introduced a reloadable feature flag to control whether to enable or disable the new technique of fetching the aws credentials via http async client.

For now this is default disabled and will be enabled by default in a follow up PR in the repo with a workaround to make usage of http async client work for AppMesh users.

See https://github.com/envoyproxy/envoy/pull/30731, https://github.com/envoyproxy/envoy/pull/31135, https://docs.google.com/document/d/1m1KE_LGDnxrXwnUC1OEKYLmw8szy4r06OX_O3JcM-wM

Testing

New tests cover the changes: yes

Description for the changelog

Option to set envoy.reloadable_features.use_http_client_to_fetch_aws_credentials via env variable.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.