aws / amazon-ecs-service-connect-agent

Amazon ECS Service Connect Agent
Apache License 2.0
25 stars 10 forks source link

[Feature Request] X-Ray support on Service Connect #81

Open mfoti opened 1 month ago

mfoti commented 1 month ago

Summary

X-Ray support on Service Connect

Description

I'd like to have the ability to configure X-Ray when using Service Connect, with these env vars:

ENABLE_ENVOY_XRAY_TRACING

AWS_XRAY_DAEMON_ADDRESS XRAY_DAEMON_PORT XRAY_SAMPLING_RATE XRAY_SAMPLING_RULE_MANIFEST XRAY_SEGMENT_NAME

liubnu commented 1 month ago

Hi @mfoti, I don't think this is a bug on Service Connect agent. Please create a feature request on https://github.com/aws/containers-roadmap/issues. We'll track on the feature request and keep it updated.

djv3 commented 1 month ago

Hi @mfoti, I've raised a similar issue on the repo that @liubnu has mentioned as we'd like to use the Jaeger tracing features as well, and it seems like perhaps both needs might be met in the same issue. https://github.com/aws/containers-roadmap/issues/2369.