aws / amazon-freertos-ble-ios-sdk

iOS SDK for FreeRTOS Bluetooth Devices
Apache License 2.0
42 stars 31 forks source link

Get afrVersion spelled gatAfrVersionOfPeripheral #2

Closed armandr closed 5 years ago

armandr commented 5 years ago

If intentional, maybe a bit confusing?

The function name starts with gat, which in BLE terms it could suggest GATT.

But the source comments suggest it should bet get:

/** Get afrVersion of the Amazon FreeRTOSperipheral .... */ public func gatAfrVersionOfPeripheral(_ peripheral: CBPeripheral)

xuaninbox commented 5 years ago

Thats indeed a typo, it should be getAfrVersionOfPeripheral. Thanks for pointing that out!

sarenameas commented 5 years ago

Commit addressing issue has been added to the repo. Closing this issue.