search

aws / amazon-freertos

DEPRECATED - See README.md
https://aws.amazon.com/freertos/
MIT License
2.54k stars 1.1k forks source link

[General] Iot_CreateDetachedThread does not have threadName argument #3486

Closed laszlopataki closed 2 years ago

laszlopataki commented 2 years ago

Briefly summarize the issue being raised In AWS C-SDK there is the Iot_CreateDetachedThread function which does not accept a name argument. The name parameter is useful to identify a certain task when calling vTaskList or using tools like Tracealyzer. Is there any particular reason why this argument does not exists and the function creates tasks with a constant "iot_thread" name?

Describe the desired outcome Iot_CreateDetachedThread accepts name parameters, so the Platform layer can be used to name Tasks.

ravibhagavandas commented 2 years ago

Hi, Could you describe more about your case for Iot_CreateDetachedThread() over xTaskCreate() API . As i looked through other repositories such as aws-iot-device-sdk-embedded-C the API is currently not being used anywhere. So instead of using the additional overhead of another abstraction, could you directly use xTaskCreate API instead ?

laszlopataki commented 2 years ago

Hi, My understanding of this abstraction layer is that the application code can be platform-independent. After porting you can run the same code on PC, on different MCUs, and with different OS.

What I did is forked the repo and created an Iot_CreateNamedDetachedThread with a name parameter.

My aim with this query was to give feedback in case these APIs are meant to be used in the future and further develop them. If it is only an experiment or some demo-related function, please ignore this post.

ravibhagavandas commented 2 years ago

@laszlopataki Yes the APIs are in experimental mode and currently there are no plans to be used on other platforms.