search

aws / amazon-freertos

DEPRECATED - See README.md
https://aws.amazon.com/freertos/
MIT License
2.54k stars 1.1k forks source link

Support for dynamic credential switching #3528

Closed KazukiMochizuki926 closed 1 year ago

KazukiMochizuki926 commented 1 year ago

Description

Supports dynamic credential switching. Fleet Provisioning uses the claim certificate and private key to connect to AWS the first time, and then uses the device-specific claim certificate and private key to connect to AWS next time. However, the current FreeRTOS library cannot support Fleet Provisioning because it uses fixed credential information. Therefore, the FreeRTOS library source code has been updated to allow dynamic credential switching. The IDT test items FullSecureSockets, FullTLS, and FulMQTT have passed.

idt_1 idt_2 idt_3

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jasonpcarroll commented 1 year ago

/bot run checks

jasonpcarroll commented 1 year ago

Hi @KazukiMochizuki926, Thank you for your contribution! I've started the CI checks and will review. Best. Jason Carroll

paulbartell commented 1 year ago

/bot run checks

gmtt commented 1 year ago

/bot run checks

cobusve commented 1 year ago

Hey all, I took a closer look a this one and we need to take a bit of change of direction here. I think making all these modules dependent on the list of credentials leaks this change into too many places.

I can clearly see that a lot of work has gone into this PR and we really appreciate that, let's work together to make sure that this makes a difference in the long term.

I think we should change this to pass the credentials into all the modules and have the list in a single place, that will not require all of these modules to be updated with this dependency which will cause all kinds of problems later on.

Also can we please move this effort to the FreeRTOS/FreeRTOS location where the new code is located?