search

aws / amazon-mwaa-docker-images

Apache License 2.0
27 stars 11 forks source link

Docker Compose setup for Airflow 2.8.0 #22

Closed rafidka closed 9 months ago

rafidka commented 9 months ago

Issue #, if available: #6

Description of changes: This PR contains configuration, and improved entrypoint and configuration, to support running Airflow locally. Currently, this setup uses Airflow 2.8.0, but we will most probably change this later to start from Airflow 2.9.x.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Mercury2699 commented 9 months ago

Should we move this to use 2.8.1 instead?

rafidka commented 9 months ago

Should we move this to use 2.8.1 instead?

No need. As stated above, we are targeting v2.9.x, so not much point in changing to an intermediate version now.

rafidka commented 9 months ago

Considering that there is a lot of rewrite based on the internal code, a formal process based on multiple incremental, small/medium PRs, each awaiting 2 approvals and potentially block other works, is going to be noticeably slow and efficient for both the developer and the reviewers. As such, I will push my incremental changes directly to a dev branch, and later on do a request to merge into main and get it reviewed. While it might seem the changes are going to be sizable for the reviewers, as mentioned earlier, considering a lot of the code is based on existing internal code, it should not that bad, and certainly better than the accumulated time spent on reviewing multiple PRs.

mayushko26 commented 9 months ago

Didn't see your update before the review. Still, I've chosen to publish them in case you'd like to address them during the rewrite.