aws / amazon-mwaa-docker-images

Apache License 2.0
24 stars 11 forks source link

Disallow the direct use of `pip install` #34

Closed rafidka closed 7 months ago

rafidka commented 7 months ago

Issue #, if available: #18

Description of changes: To make sure that developers don't accidentally use pip install directly, I implemented a script that scans the whole repository for this and report an error if it finds any such case.

While at this, I also introduced the quality-checks folder, which contains all scripts for ensuring the quality of the repository. I moved lint_bash.sh and lint_python.sh and I put the new script, pip_install_check.py under it. This way we have a central place for all such quality check scripts, which are only expected to multiple in number as the repository good bigger, more contributors are involved, and more quality control is required. The new quality-checks folder also contains a script, run_all.py that walk through the quality-checks directory and execute any executable script.

Accordingly, I also updated the GitHub workflows and pre-commit configuration to use the run_all.py script instead of manually listing all quality check scripts.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.