search

aws / amazon-mwaa-docker-images

Apache License 2.0
27 stars 11 forks source link

Disable log group creation in CloudWatch handlers #90

Closed rafidka closed 4 months ago

rafidka commented 4 months ago

Issue #, if available: #89

Description of changes:

Log group creation via the _ensure_log_group_exists() is resulting in a spam of calls to CreateLogGroup API. We are temporarily disabling log group creation until we work on a better solution. More details on this can be found in #89.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Mercury2699 commented 4 months ago

This means if user deletes a log group the logging will not work properly? Can we call something like describe-log-groups API to confirm before we call create-log-group ?

rafidka commented 4 months ago

This means if user deletes a log group the logging will not work properly?

Yes, that's correct. If the user deletes the log groups, they will stop receiving logs, which is currently the case.

Can we call something like describe-log-groups API to confirm before we call create-log-group ?

Yeah, this is the intention. See #89.

shubham22 commented 4 months ago

@rafidka - while we work on a proper solution to address deletion of log group, can we at least have some error message in scheduler/worker logs that log group is missing? It would help customers troubleshoot faster.