codecov-commenter
commented
1 year ago Codecov Report
Merging #218 (f953342) into develop (0cff376) will decrease coverage by
0.02%. The diff coverage is57.14%.
@@ Coverage Diff @@
## develop #218 +/- ##
===========================================
- Coverage 67.53% 67.52% -0.02%
===========================================
Files 121 121
Lines 5874 5872 -2
Branches 585 585
===========================================
- Hits 3967 3965 -2
Misses 1556 1556
Partials 351 351 | Impacted Files | Coverage Δ | |
|---|---|---|
| ...s/neptune/gremlin/GremlinConnectionProperties.java | 73.50% <ø> (ø) |
|
| ...eptune/gremlin/adapter/converter/SqlConverter.java | 80.55% <0.00%> (ø) |
|
| ...r/converter/ast/nodes/select/GremlinSqlSelect.java | 91.54% <0.00%> (ø) |
|
| ...erter/ast/nodes/select/GremlinSqlSelectSingle.java | 75.60% <0.00%> (ø) |
|
| ...s/neptune/jdbc/utilities/ConnectionProperties.java | 67.69% <ø> (ø) |
|
| ...software/aws/neptune/jdbc/utilities/SshTunnel.java | 8.62% <ø> (ø) |
|
| ...ware/aws/neptune/gremlin/GremlinQueryExecutor.java | 43.50% <100.00%> (-0.56%) |
:arrow_down: |
Summary
Update TinkerPop 3.4 version to latest 3.4.13
Description
The current release uses TinkerPop 3.4.8 as dependency, which may cause class path issues when using the IAM auth sigV4 plugin, as that uses 3.4.10. Bumping grader.properties to 3.4.10+ resolved the issue.
Opening as a draft for now to keep track. As we should perform some testing to make sure we are still compatible in other aspects (we should be).
Additional Reviewers
@birschick-bq @xiazcy @alexey-temnikov @kylepbit