aws / amazon-neptune-jdbc-driver

Amazon Neptune JDBC Driver by Amazon Web Services
https://aws.amazon.com/neptune/
Apache License 2.0
23 stars 13 forks source link

Remove duplicate resultSet field from PreparedStatement #246

Closed ryn5 closed 10 months ago

ryn5 commented 10 months ago

Summary

Statement is extended by PreparedStatement, and both classes currently have a field ResultSet resultSet. This led to the unexpected behaviour in #235 where getResultSet() would return null despite the statement having a valid resultSet.

Description

Changed resultSet in Statement from private to protected and removed the extra field from PreparedStatement so that it can inherit the field instead.

Related Issue

https://github.com/aws/amazon-neptune-jdbc-driver/issues/235

Additional Reviewers