aws / amazon-neptune-jdbc-driver

Amazon Neptune JDBC Driver by Amazon Web Services
https://aws.amazon.com/neptune/
Apache License 2.0
23 stars 13 forks source link

Pass all GremlinConnectionProperties to SchemaHelperGremlinDataModel #250

Closed ryn5 closed 10 months ago

ryn5 commented 10 months ago

Summary

Previously, the only gremlin connection properties being passed to SchemaHelperGremlinDataModel were contact point, port, auth scheme, enable SSL, and scan type. This change allows all properties to be passed along so that fields like serializer can be parsed from the connection request URL, for example jdbc:neptune:sqlgremlin://127.0.0.1;port=8182;authScheme=None;enableSsl=false;serializer=GRAPHSON_V3D0.

Description

Related Issue

https://github.com/aws/amazon-neptune-jdbc-driver/issues/116

Additional Reviewers

codecov-commenter commented 10 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (bbc7505) 67.40% compared to head (c80d4ed) 67.61%. Report is 2 commits behind head on develop.

Files Patch % Lines
...in/java/software/aws/neptune/common/IAMHelper.java 12.50% 7 Missing :warning:
...neptune/common/gremlindatamodel/MetadataCache.java 57.14% 2 Missing and 1 partial :warning:
...gremlindatamodel/SchemaHelperGremlinDataModel.java 0.00% 3 Missing :warning:
...ware/aws/neptune/gremlin/GremlinQueryExecutor.java 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #250 +/- ## =========================================== + Coverage 67.40% 67.61% +0.20% =========================================== Files 122 122 Lines 5882 5888 +6 Branches 585 585 =========================================== + Hits 3965 3981 +16 + Misses 1566 1554 -12 - Partials 351 353 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.