Closed ryn5 closed 10 months ago
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
bbc7505
) 67.40% compared to head (c80d4ed
) 67.61%. Report is 2 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Previously, the only gremlin connection properties being passed to SchemaHelperGremlinDataModel were contact point, port, auth scheme, enable SSL, and scan type. This change allows all properties to be passed along so that fields like serializer can be parsed from the connection request URL, for example
jdbc:neptune:sqlgremlin://127.0.0.1;port=8182;authScheme=None;enableSsl=false;serializer=GRAPHSON_V3D0
.Description
Related Issue
https://github.com/aws/amazon-neptune-jdbc-driver/issues/116
Additional Reviewers