aws / amazon-redshift-odbc-driver

Apache License 2.0
18 stars 7 forks source link

Build error with glibc >= 2.32 #27

Open rokclimb15 opened 2 months ago

rokclimb15 commented 2 months ago

Problem description

Ubuntu 22.04+ ships with glibc 2.32 or newer. From the release notes at https://sourceware.org/pipermail/libc-announce/2020/000029.html:

The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev are no longer available to newly linked binaries, and their declarations have been removed from . They are exported solely as compatibility symbols to support old binaries. All programs should use strsignal instead.

https://github.com/aws/amazon-redshift-odbc-driver/blob/main/src/pgclient/src/port/exec.c#L529

Changing that line to strsignal call corrects the build error. This probably needs to be wrapped in a different macro conditional based on glibc version.

vahid110 commented 1 month ago

Hi @rokclimb15 Thanks for the hint. I will make this change and test with other platforms and if everything is ok, I will include it in the subsequent releases.