search

aws / amazon-redshift-python-driver

Redshift Python Connector. It supports Python Database API Specification v2.0.
Apache License 2.0
202 stars 72 forks source link

Update config.py - uncommented OID 25 #215

Closed stefanks closed 1 week ago

stefanks commented 3 months ago

Hopefully solves https://github.com/aws/amazon-redshift-python-driver/issues/214

Brooke-white commented 3 months ago

Hey @stefanks , thanks for raising this PR. Can you share some details around the testing performed for this change. Mainly, did you confirm it resolved #214 i.e. were you able to successfully issue the query which previously was not working? If so, could you please add an integration test which issues this query so we can have coverage for this change in our CI?

stefanks commented 3 months ago

@Brooke-white not tested yet, having trouble setting up the dev environment with all the tests and stuff. I'm on a mac with vscode.

stefanks commented 2 months ago

@Brooke-white can you help me with this?

Brooke-white commented 1 week ago

Hi @stefanks , my apologies for my delay in response on both this issue and the associated PR. I pulled in this PR and found it did not resolve the issue at hand. This is due to the limitations around Redshift's support for array based bind parameters as I mentioned in the issue. As such, my best recommendation at this time is the work around I provided in #214