aws / amazon-redshift-python-driver

Redshift Python Connector. It supports Python Database API Specification v2.0.
Apache License 2.0
202 stars 72 forks source link

chore: publish inline type annotations #224

Closed jamesdow21 closed 1 week ago

jamesdow21 commented 1 month ago

Description

Adding a blank "py.typed" marker file will allow mypy to recognize that type annotations are provided inline.

Motivation and Context

Currently, mypy is not able to analyze any usage of this library and gives the following error

error: Skipping analyzing "redshift_connector": module is installed, but missing library stubs or py.typed marker  [import-untyped]

Fixes #223

Testing

Ran build.sh and verified that the py.typed file ends up in the sdist and wheel

No code has been changed, so I didn't add any unit tests There were 3 unit tests that failed for me locally; however, that was also the case on master before making any changes.

Screenshots (if appropriate)

Types of changes

Checklist

Brooke-white commented 1 week ago

Hi @jamesdow21 , thank you for taking the time to open this PR and for your patience. I am going to pull your changes in locally and perform some testing on my end. Once that completes, barring any issue, I anticipate we can get this PR merged.