Added ability to handle CalculateContentMD5Header flag for S3 uploads. - Githubissues

aws / amazon-s3-encryption-client-dotnet

An encryption client that allows you to secure your sensitive data before you send it to Amazon S3.

https://aws.github.io/amazon-s3-encryption-client-dotnet/

Apache License 2.0

15 stars 10 forks source link

Added ability to handle CalculateContentMD5Header flag for S3 uploads. #22

Closed ashishdhingra closed 3 years ago

ashishdhingra commented 3 years ago

Description

Added ability to handle CalculateContentMD5Header flag for S3 uploads.

Motivation and Context

Testing

Added new integration tests.
Ran integration tests locally.

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

ganeshnj commented 3 years ago

Did @ashishdhingra run both .NET Framework and .NET Standard test cases?

ashishdhingra commented 3 years ago

Did @ashishdhingra run both .NET Framework and .NET Standard test cases?

Added the integration tests for NetStandard. Please review.