aws / amazon-s3-encryption-client-dotnet

An encryption client that allows you to secure your sensitive data before you send it to Amazon S3.
https://aws.github.io/amazon-s3-encryption-client-dotnet/
Apache License 2.0
14 stars 10 forks source link

Add ServiceURL option for KMS client #45

Closed bdurrani closed 1 year ago

bdurrani commented 1 year ago

AmazonKeyManagementServiceConfig doesn't use the service url when it's setting on AmazonS3CryptoConfigurationV2

Description

Motivation and Context

I'm using LocalStack when I set ServiceURL on AmazonS3CryptoConfigurationV2 I'm seeing the Kms calling aws endpoint

See #29 for reference

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

bdurrani commented 1 year ago

@normj Hi there Is this change ok for the KMS client ServiceURL option? As discussed here: https://github.com/aws/amazon-s3-encryption-client-dotnet/pull/29

Thanks

ashovlin commented 1 year ago

I've merged this to dev, which is our staging branch for the next release. We'll reply again once the new release is out.

ashovlin commented 1 year ago

This PR was released yesterday in 2.1.0, thanks again for your contribution!