Merge PR #45 "Add ServiceURL option for KMS client" and PR#46 "Version Bump & .NET 6" - Githubissues

aws / amazon-s3-encryption-client-dotnet

An encryption client that allows you to secure your sensitive data before you send it to Amazon S3.

https://aws.github.io/amazon-s3-encryption-client-dotnet/

Apache License 2.0

14 stars 10 forks source link

Merge PR #45 "Add ServiceURL option for KMS client" and PR#46 "Version Bump & .NET 6" #47

Closed jnunn-aws closed 1 year ago

jnunn-aws commented 1 year ago

Description

Merging https://github.com/aws/amazon-s3-encryption-client-dotnet/pull/46
1. Upgrades the .NET Core 2.1 unit and integration test targets to .NET 6
2. Also does a minor version upgrade in anticipation of releasing https://github.com/aws/amazon-s3-encryption-client-dotnet/pull/45
Merging https://github.com/aws/amazon-s3-encryption-client-dotnet/pull/45

Motivation and Context

Addresses Issue https://github.com/aws/amazon-s3-encryption-client-dotnet/pull/29: AmazonKeyManagementServiceConfig doesn't use the service url when it's setting on AmazonS3CryptoConfigurationV2

Testing

Ran dotnet test locally, unit and integration tests passed.

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license