aws / amazon-sagemaker-examples

Example 📓 Jupyter notebooks that demonstrate how to build, train, and deploy machine learning models using 🧠 Amazon SageMaker.
https://sagemaker-examples.readthedocs.io
Apache License 2.0
10.14k stars 6.78k forks source link

Broken validation; due to javascript error #1461

Open v-chanikya opened 4 years ago

v-chanikya commented 4 years ago

https://github.com/awslabs/amazon-sagemaker-examples/blob/5f187521b83a2aed1842b1a550afba90a08295a6/sagemaker_neo_compilation_jobs/mxnet_mnist/input.html#L48

when trying to run the validation by drawing on the canvas observed the following error in chrome debug console Uncaught ReferenceError: IPython is not defined at set_value (:48:22) at HTMLCanvasElement. (:22:29

Note: I am using sagemaker studio to run this example

This issue looks similar to the one describes @ https://github.com/jupyterlab/jupyterlab/issues/5888#issue-400974855

fedeallocati commented 2 years ago

This issue is still happening as of November 2021.

The Javascript API changed around the date of the issue linked (jupyterlab/jupyterlab#5888) and this example hasn't updated to use ipywidgets or another method for fetching the input drawing.

Note that this has an awful side effect on the notebook: