Add Mixtral training notebook with SMP v2

Teng-xu commented 2 months ago

Issue #, if available:

Description of changes: Add notebook for training Mixtral with smp v2. The notebook is currently pending on the pr for PySDK upgrade to retrieve the correct image https://github.com/aws/sagemaker-python-sdk/pull/4560

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[ ] I have read the CONTRIBUTING doc and adhered to the example notebook best practices
[ ] I have updated any necessary documentation, including READMEs
[ ] I have tested my notebook(s) and ensured it runs end-to-end
[ ] I have linted my notebook(s) and code using black-nb -l 100 {path}/{notebook-name}.ipynb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: ec21d124bb70f1cd594bb0d9dd86760674e8346e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: ec21d124bb70f1cd594bb0d9dd86760674e8346e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: ec21d124bb70f1cd594bb0d9dd86760674e8346e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: ec21d124bb70f1cd594bb0d9dd86760674e8346e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: ec2a0f896f1097941844014b249f84a61595e150
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: ec2a0f896f1097941844014b249f84a61595e150
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: ec2a0f896f1097941844014b249f84a61595e150
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: ec2a0f896f1097941844014b249f84a61595e150
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: b91c715c08bb02cfbb66d09133829a1e3c4a6ca0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: b91c715c08bb02cfbb66d09133829a1e3c4a6ca0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: b91c715c08bb02cfbb66d09133829a1e3c4a6ca0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: b91c715c08bb02cfbb66d09133829a1e3c4a6ca0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Teng-xu commented 2 months ago

AWS CodeBuild CI Report

* CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting

* Commit ID: [b91c715](https://github.com/aws/amazon-sagemaker-examples/commit/b91c715c08bb02cfbb66d09133829a1e3c4a6ca0)

* Result: FAILED

* [Build Logs](https://qmgdeshn7c.execute-api.us-west-2.amazonaws.com/Prod/buildlogs?key=17bd04c3-50dd-4d77-875b-90132754bc0f%2Fbuild.log) (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

I have done the formatting check locally and it didn't show any issue, idk if it related to the black-nb version, I was using the latest black-nb

black-nb -l 100 smp-train-mixtral-fsdp-ep.ipynb
    24 cells left unchanged.
All done! ✨ 🍰 ✨
1 file left unchanged.

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: b76c765eacdd45f4b789becaf5e205bfcb0be34d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: b76c765eacdd45f4b789becaf5e205bfcb0be34d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: b76c765eacdd45f4b789becaf5e205bfcb0be34d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: b76c765eacdd45f4b789becaf5e205bfcb0be34d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 33f589cd13fbeb8d2f5c486627a7c568a617de17
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 33f589cd13fbeb8d2f5c486627a7c568a617de17
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 33f589cd13fbeb8d2f5c486627a7c568a617de17
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 33f589cd13fbeb8d2f5c486627a7c568a617de17
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 6bc822d40a662e57f0dbbf374441b97f059a81bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 6bc822d40a662e57f0dbbf374441b97f059a81bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 6bc822d40a662e57f0dbbf374441b97f059a81bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 6bc822d40a662e57f0dbbf374441b97f059a81bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 860d6a8d01f30f9f023b6ee3de9c2a1d760b4fba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 860d6a8d01f30f9f023b6ee3de9c2a1d760b4fba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 860d6a8d01f30f9f023b6ee3de9c2a1d760b4fba
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 860d6a8d01f30f9f023b6ee3de9c2a1d760b4fba
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 803a48551542fec118899c6ed64c64622ea46ede
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 803a48551542fec118899c6ed64c64622ea46ede
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 803a48551542fec118899c6ed64c64622ea46ede
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 803a48551542fec118899c6ed64c64622ea46ede
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 5b076648adcef51f01618b5219a86bceb0bffe39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 5b076648adcef51f01618b5219a86bceb0bffe39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 5b076648adcef51f01618b5219a86bceb0bffe39
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 5b076648adcef51f01618b5219a86bceb0bffe39
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 3be1e9efe6ceae16a9d148f383e9d3ccf0a5d069
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 3be1e9efe6ceae16a9d148f383e9d3ccf0a5d069
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 3be1e9efe6ceae16a9d148f383e9d3ccf0a5d069
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 3be1e9efe6ceae16a9d148f383e9d3ccf0a5d069
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

goswamig commented 2 months ago

Can we fix this required check and merge this notebook?

Teng-xu commented 2 months ago

Can we fix this required check and merge this notebook?

Yeah I have done the formatting check locally and it didn't show any issue, idk if it related to the black-nb version, I was using the latest black-nb version

black-nb -l 100 smp-train-mixtral-fsdp-ep.ipynb
    24 cells left unchanged.
All done! ✨ 🍰 ✨
1 file left unchanged.

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: 186e6079a3472f087fc78f8386df339f7e77b346
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-code-formatting
Commit ID: 186e6079a3472f087fc78f8386df339f7e77b346
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: 186e6079a3472f087fc78f8386df339f7e77b346
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-grammar
Commit ID: 186e6079a3472f087fc78f8386df339f7e77b346
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-amazon-sagemaker-examples-pr
Commit ID: c2f24291567392bded6897d33f02d086b57a8431
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: SageMakerNotebooksProd-USWEST2-sagemaker-examples-link-check
Commit ID: c2f24291567392bded6897d33f02d086b57a8431
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws / amazon-sagemaker-examples