UNIX Constants - Hardcoded Paths

aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).

https://aws.amazon.com/systems-manager/

Apache License 2.0

1.05k stars 324 forks source link

UNIX Constants - Hardcoded Paths #158

Closed bdwyertech closed 5 years ago

bdwyertech commented 5 years ago

The Agent hardcodes a bunch of paths, these should be configurable:

https://github.com/aws/amazon-ssm-agent/blob/89e84f79ee287ca950344e5c8915034d5fc01ede/agent/appconfig/constants_unix.go#L96-L98

Use-case: Building custom CoreOS AMI, where custom agents are supposed to be baked into OEM partition. Building this package works fine, however running it with the binaries in different bin directory causes things to fail as they look for these paths.

AmyZhangAmz commented 5 years ago

Hi @bdwyertech ,

Thank you for bringing this to our attention. We will have the team investigate this issue.

StyleT commented 5 years ago

Same issue here with CoreOS :(

hiimtu commented 5 years ago

Should be fixed with this: https://github.com/aws/amazon-ssm-agent/commit/bc7e78017a7802854fb9ddf313ca053a20e6a471