aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).
https://aws.amazon.com/systems-manager/
Apache License 2.0
1.06k stars 322 forks source link

The upload encrypted S3 bucket is not using the header ServerSideEncryption #315

Closed neelaruban closed 4 years ago

neelaruban commented 4 years ago

https://github.com/aws/amazon-ssm-agent/blob/5061338e1b0ec1baa0d3419bdcf846c573309c7d/agent/s3util/s3util.go#L93

when we have a bucket policy or a Service control policy which mandates all the S3 uploads should use the SSE header for the uploads which is part of a good security practice , the upload fails . The upload function to the encrypted S3 bucket is not using the header ServerSideEncryption currently according to the reference code .

Could we please ensure the option is handled to enable secure uploads to the session manager audit buckets

ranjrish commented 4 years ago

Same as #311