Incorrect log formatting in error message

aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).

https://aws.amazon.com/systems-manager/

Apache License 2.0

1.04k stars 322 forks source link

Incorrect log formatting in error message #384

Closed jkasarherou closed 3 years ago

jkasarherou commented 3 years ago

I noticed that when attempting to upload result logs to S3, the log formatting is incorrect.

2021-06-07 09:13:24 ERROR [S3Upload @ s3util.go.99] [ssm-document-worker] [8b130ba2-730e-4890-8af8-1b4d2c2bff96] [DataBackend] [pluginName=aws:runShellScript] Attempt %!s(int=3): Failed uploading /var/lib/amazon/ssm/i-[..]document/orchestration/[...]

Attempt %!s(int=3)

Incorrect type in formatting? https://github.com/aws/amazon-ssm-agent/blob/master/agent/s3util/s3util.go#L89

ferkhat-aws commented 3 years ago

Thank you for noticing this. We fixed the issue in version 3.0.1390.0.