search

aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).
https://aws.amazon.com/systems-manager/
Apache License 2.0
1.03k stars 323 forks source link

Update domainjoin_unix_script to fix SUSE issues #456

Open thimslugga opened 1 year ago

thimslugga commented 1 year ago

Description of changes:

There was already variables for the SUSE distribution release and service pack but the SUSEConect to enable PackageHub was hardcoded for 15.1. Newer releases have been out for years with 15.4 being recently released in 06/2022.

It's not clear to me why NetworkManager was being installed. This should not be used on SLE Server deployments. NetworkManager is only supported by SUSE for desktop workloads with SLED or the Workstation extension. All server certifications are done with wicked as the network configuration tool and using NetworkManager may invalidate them. NetworkManager is not supported by SUSE for any server workloads.

https://doc.opensuse.org/documentation/leap/reference/html/book-reference/cha-nm.html#

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

smhmhmd commented 1 year ago

Sorry, I saw this late. I will get your PR in.

thimslugga commented 1 year ago

Sorry, I saw this late.

I will get your PR in.

thank you