search

aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).
https://aws.amazon.com/systems-manager/
Apache License 2.0
1.06k stars 326 forks source link

Update domainjoin_unix_script.go #458

Closed Roy214 closed 1 year ago

Roy214 commented 2 years ago

Issue #, if available: Currently, autorid and rid idmap backend is being used together in /etc/samba/smb.conf which is creating conflict.

Description of changes: Removing the rid backend section from the script. The idmap_autorid backend provides a way to use an algorithmic mapping scheme to map UIDs/GIDs and SIDs that is more deterministic than idmap_tdb and easier to configure than idmap_rid.

The module works similar to idmap_rid, but it automatically configures the range to be used for each domain, so there is no need to specify a specific range for each domain in the forest, the only configuration that is needed is the range of uid/gids that shall be used for user/group mappings and an optional size of the ranges to be used.

The mappings of which domain is mapped to which range is stored in autorid.tdb, thus you should backup this database regularly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

smhmhmd commented 2 years ago

Thank you Prasad and @Roy214 for the meeting and fixing the customer issue, we will incorporate your change.

smhmhmd commented 2 years ago

@Roy214 Your PR is incorporated in https://github.com/aws/amazon-ssm-agent/commit/c24200f3494ee85e9ba842ed134768f5d41ba619