search

aws / amazon-ssm-agent

An agent to enable remote management of your EC2 instances, on-premises servers, or virtual machines (VMs).
https://aws.amazon.com/systems-manager/
Apache License 2.0
1.03k stars 323 forks source link

[SeamlessDomainJoin] Ubuntu - Retrieve and set interface name dynamically #499

Open jaseblenner opened 1 year ago

jaseblenner commented 1 year ago

SeamlessDomainJoin has been configured to retrieve interface name dynamically everywhere but the do_dns_config function

Issue #, if available: 469

Description of changes: As per issue 469 newer tX (t3 and above) EC2 instances now use interface names of ensX as opposed to eth0

Issue #469 / PR #470 has been opened and merged to remediate this however the do_dns_config function needs to be added to configure the interface name dynamically also. This PR/merge request handles this and has been tested.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

smhmhmd commented 1 year ago

Thanks for this PR, @jaseblenner We will incorporate it after internal review.