search

aws / amazon-vpc-cni-k8s

Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS
Apache License 2.0
2.23k stars 728 forks source link

valid openAPIV3 Schema #2963

Open cyberox opened 3 weeks ago

cyberox commented 3 weeks ago

What would you like to be added: Update the ENIConfig CRD to include a valid openAPIV3 Schema

Why is this needed: When creating ENIConfig resources using Terraform manifest resources, I receive a warning:

│ Warning: This custom resource does not have an associated OpenAPI schema.
│
│ We could not find an OpenAPI schema for this custom resource. Updates to this resource will cause a forced replacement.

Terraform issue: https://github.com/hashicorp/terraform-provider-kubernetes/issues/1382

orsenthil commented 3 weeks ago

aws-vpc-cni will need to add complete schema definition here - https://github.com/aws/amazon-vpc-cni-k8s/blob/e65d256c6dfa3e2dc318c6319b3c1a70addfa764/config/master/aws-k8s-cni.yaml#L33

similar to AWS LB controller does here - https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/install/v2_2_4_full.yaml#L37

orsenthil commented 3 weeks ago

@cyberox - would you like to use these changes in your terraform config https://github.com/aws/amazon-vpc-cni-k8s/pull/2969 and see if the terraform behavior is fixed?

cyberox commented 3 weeks ago

@orsenthil - yes, those changes fix the issue.