Make the eniconfig name as string in the template.

[orsenthil]

When an ENIConfig with name is given a number, instead of string,

apiVersion: crd.k8s.amazonaws.com/v1alpha1
kind: ENIConfig
metadata:
    name: 3
    namespace: kube-system
spec:
    securityGroups:
        - sg-xx
        - sg-xx2
    subnet: subnet-xxx

the helm chart apply throws an error stating

unable to ssa object &{Object:map ... } ... name is required

We have to make the eniconfig name as string in the template.

https://github.com/aws/amazon-vpc-cni-k8s/blob/e8faf2f87615a70f8319d6fdf4df8324ffa4cc20/charts/aws-vpc-cni/templates/eniconfig.yaml#L6

[yash97]

From the values.yaml, It seems like key is expected to be AZ:- https://github.com/aws/amazon-vpc-cni-k8s/blob/e8faf2f87615a70f8319d6fdf4df8324ffa4cc20/charts/aws-vpc-cni/values.yaml#L220. Readme of charts also confirms that - https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/aws-vpc-cni/README.md#configuration. But in code I do not see this name being used anywhere.

[orsenthil]

I think, it is the metadata.name spec that is asserting the type here - https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata

In docs, we recommend the AZ name, previously used to have a suffix-with AZ name. Not sure, how the customer generated the ENIConfig; but they ended up creating a number for name,that threw that error.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days