aws / amazon-vpc-cni-k8s

Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS
Apache License 2.0
2.26k stars 735 forks source link

Is the `VPC_ID` env var used? #2999

Open SharpEdgeMarshall opened 2 months ago

SharpEdgeMarshall commented 2 months ago

What happened:

We are wondering if the env var VPC_ID added by eks is still used by the vpc-cni plugin, there's no trace of its usage in the doc or the code. We need to know it because we are self-managing the vpc-cni addon so we need to configure all the needed env vars.

Environment:

orsenthil commented 2 months ago

We are wondering if the env var VPC_ID added by eks is still used by the vpc-cni plugin

No. We don't. But vpc-id is very important and we get it from the IMDS of the machine https://github.com/aws/amazon-vpc-cni-k8s/blob/18181594cb431b87eda914a34386d9992a6f1880/pkg/awsutils/awsutils.go#L461

SharpEdgeMarshall commented 2 months ago

Sure, I know that; we wondered why EKS put that env var if it's not used.

github-actions[bot] commented 1 day ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days