search

aws / amazon-vpc-cni-k8s

Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS
Apache License 2.0
2.28k stars 743 forks source link

Fix fetching enimetadata #3035

Closed Pavani-Panakanti closed 2 months ago

Pavani-Panakanti commented 2 months ago

What type of PR is this? improvement

Which issue does this PR fix?:

What does this PR do / Why do we need it?:

Testing done on this change: Tested cni and ipamd is working as expected by scaling pods and creating new ENIs

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades? Has updating a running cluster been tested?: No

Does this change require updates to the CNI daemonset config files to work?: No

Does this PR introduce any user-facing change?: No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

orsenthil commented 2 months ago 
> Which issue does this PR fix?

Description as well as output verification will a help a lot with this PR.

orsenthil commented 2 months ago

Code change looks good to me. I think, we need to explain that if networkCard == 0 is the safe operation to do in the comments. Assuming it is.

Pavani-Panakanti commented 2 months ago

Code change looks good to me. I think, we need to explain that if networkCard == 0 is the safe operation to do in the comments. Assuming it is.