aws / amazon-vpc-cni-k8s

Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS
Apache License 2.0
2.28k stars 743 forks source link

[Documentation] Potential miscalculation in WARM_PREFIX_TARGET, WARM_IP_TARGET, MINIMUM_IP_TARGET docs #3083

Open Tsonov opened 1 month ago

Tsonov commented 1 month ago

Not a product issue but potential documentation bug.

I could be misunderstanding how the WARM/MIN calculations work, or the following line from docs/prefix-and-ip-target.md is wrong.

Since MINIMUM_IP_TARGET=20, CNI attaches 2 prefixes (32 IPs) to ensure 20 are available. There are no pods to use any IPs so all 32 IPs are Unused.

So last column should say 32 instead of 16 and Attached Prefixes+Unused Prefixes should say 2 instead of 1. Is that the case or the calculation above is not OK?

AFAICS WARM_IP_TARGET has no effect in this case, right?

Instance type WARM_PREFIX_TARGET WARM_IP_TARGET MINIMUM_IP_TARGET Pods ENIs Pod per ENIs Attached Prefixes Pod per Prefixes Unused Prefixes Prefixes per ENI Unused IPs
t3.small - 7 20 0 1 0 1 0,0 1 2 16