search

aws / amazon-vpc-cni-k8s

Networking plugin repository for pod networking in Kubernetes using Elastic Network Interfaces on AWS
Apache License 2.0
2.28k stars 743 forks source link

iptables operation add timeout and retry exponentially #3092

Open phuhung273 opened 1 month ago

phuhung273 commented 1 month ago

What type of PR is this?

Which issue does this PR fix?:

2945

What does this PR do / Why do we need it?:

Testing done on this change:

Will this PR introduce any new dependencies?:

Yes. retry util library: github.com/cenkalti/backoff/v4

Will this break upgrades or downgrades? Has updating a running cluster been tested?: No

Does this change require updates to the CNI daemonset config files to work?:

No

Does this PR introduce any user-facing change?:

No

iptables operation add timeout and retry exponentially

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

phuhung273 commented 1 month ago

@yash97 may I ask for your help on how to unit test this implementation

phuhung273 commented 1 month ago

@yash97 I found out how to test. But the PR is quite big now, understand you dont prefer that

phuhung273 commented 2 weeks ago

@yash97 want to know your thought on this PR

orsenthil commented 2 weeks ago

@phuhung273 - I will review the PR and let you know.