Newer controller-gen doesn't correctly recognize markers. Need upgrade.

aws / amazon-vpc-resource-controller-k8s

Controller for managing Trunk & Branch Network Interfaces on EKS Cluster using Security Group For Pod feature and IPv4 Addresses for Windows Node.

Apache License 2.0

77 stars 52 forks source link

Newer controller-gen doesn't correctly recognize markers. Need upgrade. #199

Open haouc opened 1 year ago

haouc commented 1 year ago

What would you like to be enhanced: Looks like the controller is still using 0.6.x controller-tools to manage markers. Controller-gen has a breaking change from 0.7 and the latest version is 0.11.x. This project need to upgrade markers to use newer controller-tools. Why is the change needed and what use case will it solve: This project is still using an old controller-tool version. It should be upgraded to work with newer controller-tools version.

sushrk commented 7 months ago

Partly addressed in https://github.com/aws/amazon-vpc-resource-controller-k8s/pull/369

go/v4 is the default version now, https://book.kubebuilder.io/plugins/go-v4-plugin

Keeping this issue open till be move to v4.