CloudFormation/CDK Custom Domain Support For AppRunner

tcldr commented 2 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do * not help prioritize the request If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request There is no CloudFormation support for creating custom domains for AWS App Runner. There should be a new resource created called something like AWS::AppRunner::CustomDomain. The related links included have the fields that need to be included.

This should support the creation of relevant constructs in the CDK (https://github.com/aws/aws-cdk/issues/19740)

Describe alternatives you've considered Fargate/ECS

Additional context

Dupe of https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/1092

Attachments https://docs.aws.amazon.com/apprunner/latest/api/API_AssociateCustomDomain.html https://docs.aws.amazon.com/apprunner/latest/api/API_DescribeCustomDomains.html https://docs.aws.amazon.com/apprunner/latest/api/API_DisassociateCustomDomain.html

rhbecker commented 2 years ago

On the CFN coverage roadmap, issue 1092 (referenced above) is showing as shipped, but issue 1146 seems to indicate that it's not actually shipped.

In other contexts, I've experienced features being shipped but not yet documented. It's unclear which situation we're in with this feature - clarifying that might be a good place to start.

ke-dojoit commented 1 year ago

+

ke-dojoit commented 1 year ago

+1

cyber-gh commented 1 year ago

There's a workaround using Cloudformation with custom providers - https://binx.io/2023/01/15/configure-custom-domain-for-aws-apprunner-service-using-cloudformation/

nefilim commented 1 year ago

Given such basic functionality is still missing after almost a year and the CDK lib is still in alpha and still not have parity with Cloudformation, it would seem that AWS isn't investing in AppRunner anymore? Probably best to migrate away 😞

yaronlevi commented 1 year ago

@nefilim Hi Peter. Do you know why this is not being worked on? We are considering a move from Render.com to App Runner (specifically because feature clients might require a dedicated VPC and Render can't offer this for now). Are you using App Runner, and do you think AWS has lowered the investment in it?

Also, do you know App runner, does not have an SLA?

CleanShot 2023-05-30 at 10 36 22@2x

worldofgeese commented 1 year ago

Given such basic functionality is still missing after almost a year and the CDK lib is still in alpha and still not have parity with Cloudformation, it would seem that AWS isn't investing in AppRunner anymore? Probably best to migrate away disappointed

@nefilim, what do you believe they are investing in instead? Copilot CLI is getting a lot of love and one of its deployment targets is App Runner with ECS on Fargate as alternative. It does look like ECS on Fargate is the default, however.