aws / apprunner-roadmap

This is the public roadmap for AWS App Runner.
https://aws.amazon.com/apprunner/
Other
301 stars 14 forks source link

`AWS::AppRunner::Service` should fail when update service actually failed but was rolled back by Service #209

Open riywo opened 1 year ago

riywo commented 1 year ago

Community Note

Tell us about your request What do you want us to build?

We're building a simple CDK pipeline with @aws-cdk/aws-apprunner-alpha. When we misconfigure something, App Runner deployment (update service) fails, for example because wrong port is set.

However, CloudFormation update of AWS::AppRunner::Service always succeeds because App Runner automatically rollback to the previous successful revision and AWS::AppRunner::Service only sees the final status of the service.

This breaks CDK pipeline's concept e.g. if CloudFormation deployment fails on Staging, it stops promotion there and won't deploy such problematic revision to production.

Ideally, AWS::AppRunner::Service should fail when the intended deployment fails on App Runner side.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

No idea.

Additional context Anything else we should know?

N/A

Attachments If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

st3fus commented 1 year ago

Same issue here, I update it, it fails (It shows nothing in logs why it failed) and then it just rollbacks it. Like this is unbearable...

Nick-Lucas commented 4 months ago

Same experience with Terraform, we need to ability to disable auto-rollbacks at very least