aws / aws-app-mesh-controller-for-k8s

A controller to help manage App Mesh resources for a Kubernetes cluster.
Apache License 2.0
187 stars 109 forks source link

ENDPOINTS response type not reflected in App Mesh with TLS enabled #518

Open dms486 opened 3 years ago

dms486 commented 3 years ago

Describe the bug When enabling TLS on a virtual node using ACM PCA, the DNS service discovery response type of ENDPOINTS is not registered in the App Mesh configuration.

Steps to reproduce Create a VirtualNode resource in Kubernetes with a configuration similar to below with the responseType: ENDPOINTS and TLS enabled with ACM PCA.

Expected outcome I expected the responseType to be set to ENDPOINTS for the VirtualNode in the App Mesh console but it does not get set.

Environment

Additional Context:

apiVersion: appmesh.k8s.aws/v1beta2
kind: VirtualNode
metadata:
  name: test-service
  namespace: appmesh-sandbox
spec:
  podSelector:
    matchLabels:
      app: test-service
  listeners:
    - portMapping:
        port: 8080
        protocol: http
      healthCheck:
        protocol: http
        path: '/actuator/health/liveness'
        healthyThreshold: 3
        unhealthyThreshold: 3
        timeoutMillis: 3000
        intervalMillis: 5000
      tls:
        mode: STRICT
        certificate:
          acm:
            certificateARN: <cert ARN>
  logging:
    accessLog:
      file:
        path: /dev/stdout
  serviceDiscovery:
    dns:
      hostname: test-service.appmesh-sandbox.svc.cluster.local
      responseType: ENDPOINTS
cgchinmay commented 3 years ago

I will check this and get back to you . Thanks