search

aws / aws-app-mesh-controller-for-k8s

A controller to help manage App Mesh resources for a Kubernetes cluster.
Apache License 2.0
182 stars 110 forks source link

Update PodDisruptionBudget API version for Kubernetes 1.25 #754

Closed igreg closed 6 months ago

igreg commented 6 months ago

Issue #, if available:

Description of changes:

The Beta API version (policy/v1beta1) of PodDisruptionBudget is no longer served as of version 1.25. cf. https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-25

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

igreg commented 6 months ago

I am taking over PR #723 which had outstanding comments that had not been resolved. I am currently blocked and unable to deploy the appmesh-controller to an EKS cluster upgraded to 1.25.

igreg commented 6 months ago

@BennettJames Would you be able to help with this PR? I saw you commented on the PR I'm taking over.

BennettJames commented 6 months ago

Hey Greg,

This looks good; I added an approval. I'll merge it once the build succeeds.

igreg commented 6 months ago

Thanks @BennettJames. Sorry, I merged the master into the PR after the build had succeeded believing this would help but didn't realize the workflows were also requiring approval so it's awaiting your approval again.