search

aws / aws-app-mesh-controller-for-k8s

A controller to help manage App Mesh resources for a Kubernetes cluster.
Apache License 2.0
182 stars 110 forks source link

Fix VirtualRouter route deletion sequence #768

Closed dhild closed 2 months ago

dhild commented 3 months ago

This addresses a few rough edges with updating a VirtualRouter, by removing routes which will be deleted before updating the listeners. After this change, it is possible to update the listener protocol on the CRD in one step. It is also possible to remove the listener at the same time as the routes which use that listener.

Issue #, if available: #767

Description of changes:

Adds a step to the VirtualRouter reconciliation sequence which identifies the routes to remove and deletes them before the corresponding listeners are updated. This allows a greater range of valid API changes to be successfully reconciled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

BennettJames commented 2 months ago

Merged.

It might be a bit before we release this as the default, but we can try to put up a version you can use in the meantime with a helm override if that'd be useful.

dhild commented 2 months ago

Great, thanks! I would appreciate having an official image to run these changes in test environments, if it’s not too much trouble.