adding feature to set TLS configuration

aws / aws-app-mesh-controller-for-k8s

A controller to help manage App Mesh resources for a Kubernetes cluster.

Apache License 2.0

182 stars 110 forks source link

adding feature to set TLS configuration #776

Closed kangsheng89 closed 1 month ago

kangsheng89 commented 1 month ago

Issue #, if available:

Description of changes: This is enable user to configure TLS setting for the controller manager

setting for minimum TLS version
setting for preferred TLS cipher suites

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kangsheng89 commented 1 month ago

@ysdongAmazon could help to review this?

kangsheng89 commented 1 month ago

@sshver could help to approve and trigger the workflow?

kangsheng89 commented 1 month ago

@sshver once this done, do i require to update helm chart at https://github.com/aws/eks-charts/tree/master/stable/appmesh-controller?

joesbigidea commented 1 month ago

@kangsheng89 Since we want to get this change out quickly @sshver made a few small structural changes to this in a separate PR. That PR has been manually tested and we'll go ahead and get that one merged and released. Thank you for your contribution.

kangsheng89 commented 1 month ago

Thank you! @joesbigidea and @sshver