search

aws / aws-app-mesh-examples

AWS App Mesh is a service mesh that you can use with your microservices to manage service to service communication.
MIT No Attribution
856 stars 397 forks source link

[BUG] #559

Closed ssccio closed 1 year ago

ssccio commented 1 year ago

Important note on security disclosures: If you think you’ve found a potential security issue, please do not post it in the Issues. Instead, please follow the instructions here or email AWS security directly.

Describe the bug The microservices appear to be missing from the ecs-canary-deployments-pipeline example.

Platform ECS

To Reproduce Steps to reproduce the behavior:

  1. cd blogs/ecs-canary-deployments-pipeline
  2. make create-shared-cloudformation-stack

./setup/scripts/create_shared_cloudformation_stack.sh Starting the zipping activity of the microservices code ./setup/scripts/create_shared_cloudformation_stack.sh: line 17: cd: setup/scripts/../../microservices/yelb-ui: No such file or directory ./setup/scripts/create_shared_cloudformation_stack.sh: line 18: cd: setup/scripts/../../microservices/yelb-db: No such file or directory ./setup/scripts/create_shared_cloudformation_stack.sh: line 19: cd: setup/scripts/../../microservices/yelb-appserver: No such file or directory ./setup/scripts/create_shared_cloudformation_stack.sh: line 20: cd: setup/scripts/../../microservices/yelb-redisserver: No such file or directory

Expected behavior Microservices to be present.

ysdongAmazon commented 1 year ago

Hello, Will reproduce the example and get back to you soon. Thanks

BennettJames commented 1 year ago

It appears that there may have been some missing files from the eks demo that need to either be copied or correctly referred to from the ecs demo.

We'll have to straighten out the files and make sure both work as expected.

ssccio commented 1 year ago

I have since found another workshop at https://catalog.us-east-1.prod.workshops.aws/workshops/869f7eee-d3a2-490b-bf9a-ac90a8fb2d36/en-US/5-advanced/lab5-canarydeploy that refers to this repository with the instructions to git clone https://github.com/ratnopamc/yelb.git && mv yelb microservices

ysdongAmazon commented 1 year ago

You are right, you can follow the steps of this blob to reproduce: The walkthrough for this tutorial: https://aws.amazon.com/cn/blogs/containers/create-a-pipeline-with-canary-deployments-for-amazon-ecs-using-aws-app-mesh/

ysdongAmazon commented 1 year ago

Confirmed the right repo